Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build for 5.x-dev #19746

Merged
merged 3 commits into from Sep 19, 2022
Merged

fix build for 5.x-dev #19746

merged 3 commits into from Sep 19, 2022

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Sep 18, 2022 •
edited

Description:

Changes:

  • Add description column to tagmanager tables missing it in omnifixture dump
  • Fix random failure having to do w/ floating point comparison.

Review

@diosmosis diosmosis added this to the 5.0.0 milestone Sep 18, 2022
@diosmosis diosmosis added the Needs Review PRs that need a code review label Sep 18, 2022
peterhashair
peterhashair approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the random fail and tag manager missing column

1) Piwik\Plugins\Insights\tests\Integration\ApiTest::test_getInsights_ShouldReturnCorrectMetadata
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
     'totals' => Array (
         'nb_visits' => 42
         'growth_percent' => 0
-        'growth_percent_numeric' => 354.2
+        'growth_percent_numeric' => 354.20000000000005
         'grown' => 0
         'value_old' => 38
         'value_new' => 30

@diosmosis diosmosis merged commit 16e82f1 into 5.x-dev Sep 19, 2022
@diosmosis diosmosis deleted the 5.x-dev-fix-build branch September 19, 2022 01:32
@sgiehl sgiehl mentioned this pull request Oct 6, 2022
Merged
11 tasks
bx80 pushed a commit that referenced this pull request Nov 25, 2022
@diosmosis @bx80
fix build for 5.x-dev (#19746)
0613b50 
* add description column to tagmanager tables missing it in omnifixture dump

* update expected screenshots

* add delta to assert
bx80 pushed a commit that referenced this pull request Nov 25, 2022
@diosmosis @bx80
fix build for 5.x-dev (#19746)
af8fac2 
* add description column to tagmanager tables missing it in omnifixture dump

* update expected screenshots

* add delta to assert
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

@sgiehl sgiehl Awaiting requested review from sgiehl

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @peterhashair @sgiehl