@diosmosis opened this Pull Request on September 18th 2022 Member

Description:

Refs #16363

I'm finishing up #16773, and thought it would be better to review/merge it piecemeal. This PR adds nb_profilable as a metric to VisitsSummary.get. It's just the sum of all profilable visits, and will be used in further PRs.

Review

@github-actions[bot] commented on October 1st 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@diosmosis commented on October 11th 2022 Member

@sgiehl modified the code and asked questions for other items

@sgiehl commented on October 12th 2022 Member

@diosmosis left another comment. Besides that the target still needs to be changed to 5.x-dev and a couple of tests are failing...

@diosmosis commented on October 12th 2022 Member

@sgiehl can you confirm with @mattab the target should be 5.x-dev? I was told it would be better to put this in 4.x. Or is 4.12 the last 4.x version?

@sgiehl commented on October 12th 2022 Member

@justinvelluppillai told me 4.12. was the last planned release before Matomo 5. There will be a patch release 4.12.1 though, but the changes in this PR might be a bit too big for that.

@diosmosis commented on October 12th 2022 Member

Ok, I'll switch to 5.x-dev

@mattab commented on October 12th 2022 Member

i'm thinking maybe we will have a 4.13 release i'm thinking? So maybe you could wait until switching to 5.x @diosmosis

@sgiehl commented on October 13th 2022 Member

@mattab please clarify that with @justinvelluppillai
We have already merged a couple of changes to 5.x-dev, as there was no plan for 4.13
Also we will need to wait with merging this one until 4.12.1 has been released if it should target 4.x-dev. On 5.x-dev we could directly merge

@diosmosis commented on October 16th 2022 Member

@mattab @justinvelluppillai any update on ^?

@github-actions[bot] commented on October 24th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@justinvelluppillai commented on October 25th 2022 Member

@mattab I am happy either way, you can maybe decide here? It is likely there will be a 4.13 to release a few things that need to be done for this quarter

@github-actions[bot] commented on November 2nd 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions[bot] commented on December 15th 2022 Contributor

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@sgiehl commented on December 15th 2022 Member

@justinvelluppillai Has there been a decision whether to merge this into the next 4.x patch release or keep it for 5.x?

@github-actions[bot] commented on December 23rd 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

Powered by GitHub Issue Mirror