Refs #16363
I'm finishing up #16773, and thought it would be better to review/merge it piecemeal. This PR adds nb_profilable as a metric to VisitsSummary.get. It's just the sum of all profilable visits, and will be used in further PRs.
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers
@sgiehl modified the code and asked questions for other items
@diosmosis left another comment. Besides that the target still needs to be changed to 5.x-dev
and a couple of tests are failing...
@justinvelluppillai told me 4.12. was the last planned release before Matomo 5. There will be a patch release 4.12.1 though, but the changes in this PR might be a bit too big for that.
i'm thinking maybe we will have a 4.13 release i'm thinking? So maybe you could wait until switching to 5.x @diosmosis
@mattab please clarify that with @justinvelluppillai
We have already merged a couple of changes to 5.x-dev
, as there was no plan for 4.13
Also we will need to wait with merging this one until 4.12.1
has been released if it should target 4.x-dev. On 5.x-dev we could directly merge
@mattab @justinvelluppillai any update on ^?
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers
@mattab I am happy either way, you can maybe decide here? It is likely there will be a 4.13 to release a few things that need to be done for this quarter
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers
@justinvelluppillai Has there been a decision whether to merge this into the next 4.x patch release or keep it for 5.x?
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers