Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong number format for thousands in languages different by english #19726

Closed
jr-ewing opened this issue Sep 13, 2022 · 1 comment · Fixed by #19727
Closed

Wrong number format for thousands in languages different by english #19726

jr-ewing opened this issue Sep 13, 2022 · 1 comment · Fixed by #19727
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@jr-ewing
Copy link

In the evaluation of engagement, the format of the numbers is different in German than in English. It's probably because of the thousands separator. The problem probably existed earlier in other places, e.g. #15356.

Expected Behavior

The representation of the number 9946 should read 9.946 and not be truncated

Current Behavior

In German, the number is truncated to two decimal places if the number is greater than 1000.

Steps to Reproduce (for Bugs)

First, in English, call up the engagement evaluation in the menu under Behavior. Here you should choose the period so that more than a thousand visitors are counted.
Then go to personal settings and change the language to German. In the Behavior -> Commitment menu, you can then see the changed thousands formatting.

Your Environment

  • Matomo Version: 4.11
  • PHP Version: 7.4.30
  • Server Operating System: Ubuntu
  • Browser: Firefox
  • Operating System: Linux
    Webserver: Apache

Auswahl_4419
Auswahl_4420

@jr-ewing jr-ewing added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Sep 13, 2022
@sgiehl
Copy link
Member

sgiehl commented Sep 13, 2022

Hi Thomas,

Thanks for creating this issue. I was able to reproduce that one and will prepare a fix for the next release shortly.

Cheers,

@sgiehl sgiehl self-assigned this Sep 13, 2022
@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Sep 13, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants