Added code to unsanitize user email on update #19698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
Looks good to me. Had some thoughts if it might be useful to have some additional tests for that. But actually the change won't have any effect on Matomo core itself, as Matomo doesn't allow creating users having an email containing a special char.
Also as we most likely will start working on removing the auto-sanitizing stuff in the new future and maybe also on supporting email with special chars, there will be new changes coming, where adding tests might be required nevertheless.
sgiehl
added
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added code to unsanitize user email input on update.
Fixes: matomo-org/plugin-LoginLdap#293
Review