Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdblockIsMaybeUsed warning refers to Matomo directly, breaking WhiteLabel #19688

Open
vigilyn opened this issue Aug 29, 2022 · 1 comment
Open

AdblockIsMaybeUsed warning refers to Matomo directly, breaking WhiteLabel #19688

vigilyn opened this issue Aug 29, 2022 · 1 comment
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.
Milestone
For Prioritization

Comments

@vigilyn
Copy link

vigilyn commented Aug 29, 2022

The Adblock Warning in the language files "AdblockIsMaybeUsed" should refer to whatever the custom brand/product name is set to and not "Matomo" directly.

Here is the link to the English version:

matomo/plugins/CoreHome/lang/en.json

Line 98 in 2b35b46

"AdblockIsMaybeUsed": "In case you are using an ad blocker, please disable it for this site to make sure Matomo works without any issues.",

@vigilyn vigilyn added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Aug 29, 2022
@sgiehl
Copy link
Member

sgiehl commented Aug 29, 2022

@vigilyn You are referring to the premium plugin "Whitelabel", right? I'm not sure if that needs to be changed in core, or if the plugin has an issue.
@AltamashShaikh Do you know this issue or can maybe say something on it? If it's something that needs to be fixed in the plugin, we should maybe create an internal issue for it and close the issue here. Or does this require changes in core?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.
Projects
None yet
Milestone
For Prioritization
Development

No branches or pull requests
3 participants
@vigilyn @sgiehl @innocraft-automation