Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy link after token been sent for the user doesnt have email set up #19683

Closed
wants to merge 23 commits into from

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Aug 29, 2022

Description:

Add copy link after the token has been sent.

Review

Peter added 2 commits August 29, 2022 12:56
updates
update invite token links
@peterhashair peterhashair added this to the 4.12.0 milestone Aug 29, 2022
@peterhashair peterhashair added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 29, 2022
@justinvelluppillai
Copy link
Contributor

@peterhashair I've just taken a look to see if I can progress this in your absence but I can't see it's including many of @Javi-Ormaechea's UI suggestions and not clear what compromises have been made or why.

The designs he provided have adjusted headings, moved info text into better locations, include modals (I understand maybe this isn't possible but based on the technical requirements maybe he could suggest a better way that is possible rather than us guessing at UI), and different flows.

Also the success message right now always seems to say "the invite has been resent to user" which I don't think is correct.

@peterhashair peterhashair changed the title Add copy link after token been sent for the user doesnt have emai set up Add copy link after token been sent for the user doesnt have email set up Sep 1, 2022
@peterhashair
Copy link
Contributor Author

@justinvelluppillai just double check, so we want the design popup up workflow, and also move the copy link to notification
image

@justinvelluppillai
Copy link
Contributor

@peterhashair ideally as close as possible to @Javi-Ormaechea's design as possible. If there are technical limitations (ie we don't store the token) then discussing how this would impact the design with @Javi-Ormaechea would be the next step so that he can come up with a new design that is technically possible and serves the UI best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants