@peterhashair opened this Pull Request on August 29th 2022 Contributor

Description:

Add copy link after the token has been sent.

Review

@justinvelluppillai commented on September 1st 2022 Member

@peterhashair I've just taken a look to see if I can progress this in your absence but I can't see it's including many of @Javi-Ormaechea's UI suggestions and not clear what compromises have been made or why.

The designs he provided have adjusted headings, moved info text into better locations, include modals (I understand maybe this isn't possible but based on the technical requirements maybe he could suggest a better way that is possible rather than us guessing at UI), and different flows.

Also the success message right now always seems to say "the invite has been resent to user" which I don't think is correct.

@peterhashair commented on September 5th 2022 Contributor

@justinvelluppillai just double check, so we want the design popup up workflow, and also move the copy link to notification
image

@justinvelluppillai commented on September 5th 2022 Member

@peterhashair ideally as close as possible to @Javi-Ormaechea's design as possible. If there are technical limitations (ie we don't store the token) then discussing how this would impact the design with @Javi-Ormaechea would be the next step so that he can come up with a new design that is technically possible and serves the UI best.

This Pull Request was closed on September 6th 2022
Powered by GitHub Issue Mirror