filtering a user's permissions, capabilities fixes #19680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update some get role and capabilities
peterhashair
changed the title
added 3 commits
August 26, 2022 14:25
update query and add tests
update query
update access
sgiehl
added
the
not-in-changelog
sgiehl
requested changes
Aug 30, 2022
There was a problem hiding this comment.
@peterhashair It seems our UI tests are currently not covering that case. Might be good to also add a simple test, that filters by permission, after this one: https://github.com/matomo-org/matomo/blob/4.x-dev/plugins/UsersManager/tests/UI/UsersManager_spec.js#L617-L622
added 3 commits
August 31, 2022 11:01
add UI tests
|
@sgiehl updated UI tests |
sgiehl
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes: #19679
The problem is caused by matomo_access table, Capabilities and access are in one column when the filter is by where it cleans the other access
Review