Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SiteSelector initially might show too many sites #19670

Merged
merged 1 commit into from Aug 25, 2022
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 24, 2022

Description:

Our site selector can be use with the option onlySitesWithAdminAccess = true. In that case the selector should only show sites the user currently has admin access to. We are using that in a couple of plugins, where the site selector is shown for configuration purpose.

Currently the site selector initially always loads the list of all sites and does not respect this setting. This might cause trouble when the user selects a site, he actually should not be able to select.

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Aug 24, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Aug 24, 2022
@sgiehl sgiehl requested a review from diosmosis August 24, 2022 15:58
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sgiehl sgiehl merged commit 006a453 into 4.x-dev Aug 25, 2022
@sgiehl sgiehl deleted the fixsiteselector branch August 25, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants