New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[automatic submodule updates] #19644
Conversation
It took me a couple of hours to figure out, why the latest updates in TagManager let our UITestFixture start failing to set up. |
There seem to be a lot of UI tests failing, I can't see any good reason for that based on the change, so I've trigger another test build in case there was a transient issue with the test environment. |
I really don't have a clue why the tests start failing with the changes I've added. Tried it in a couple of different ways now, but all seem to produce some unrelated failures in the UI tests. The basic difference now, is that the updater now also executes the update scripts of plugins. In that case this are AnonymousPiwikUsageMeasurement and TagManager. But running those scripts shouldn't produce such failures. I already spent too much time trying to find a quick fix solution here, so I'll let you (@justinvelluppillai) decide how to proceed with this:
another option would be to fully refactor how our ui tests work, but that would be out of scope for sure, as we can't update the TagManager submodule till this was fixed and did not yet have a discussion how our UI tests could be handled in the future. |
@sgiehl yes we'll need to put some more time in to figure this out. It seems like some of the fixtures aren't loaded in the same way or something? I'll see if @peterhashair has the same issues with the github action tests runner, after that we can discuss again. |
Updated submodules: