Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automatic submodule updates] #19644

Closed
wants to merge 4 commits into from
Closed

[automatic submodule updates] #19644

wants to merge 4 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

Updated submodules:

  • plugins/TagManager

@sgiehl
Copy link
Member

sgiehl commented Aug 19, 2022

It took me a couple of hours to figure out, why the latest updates in TagManager let our UITestFixture start failing to set up.
This was caused by adding a update script to the plugin. Due to the way we used to set up the fixture, the update script wasn't executed, causing the database being out of sync. Found a proper solution, which should fix it. Might be good if someone could have a quick look at the test fix.

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review labels Aug 19, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Aug 19, 2022
@sgiehl sgiehl requested a review from bx80 August 19, 2022 15:52
@bx80
Copy link
Contributor

bx80 commented Aug 21, 2022

There seem to be a lot of UI tests failing, I can't see any good reason for that based on the change, so I've trigger another test build in case there was a transient issue with the test environment.

@sgiehl
Copy link
Member

sgiehl commented Aug 22, 2022

I really don't have a clue why the tests start failing with the changes I've added. Tried it in a couple of different ways now, but all seem to produce some unrelated failures in the UI tests. The basic difference now, is that the updater now also executes the update scripts of plugins. In that case this are AnonymousPiwikUsageMeasurement and TagManager. But running those scripts shouldn't produce such failures.
On my local dev machine setting up the fixture works and the tests failing on travis are also passing (at least the ones I tried).

I already spent too much time trying to find a quick fix solution here, so I'll let you (@justinvelluppillai) decide how to proceed with this:

  • keep trying to find a fix for the current code by debugging for an unpredictable amount of time
  • update the ui test fixture, which might easily take up to two days, as it wasn't done since Matomo 3.16 and thus will take some time to validate all the changes...

another option would be to fully refactor how our ui tests work, but that would be out of scope for sure, as we can't update the TagManager submodule till this was fixed and did not yet have a discussion how our UI tests could be handled in the future.

@sgiehl sgiehl removed the Needs Review PRs that need a code review label Aug 22, 2022
@justinvelluppillai
Copy link
Contributor

@sgiehl yes we'll need to put some more time in to figure this out. It seems like some of the fixtures aren't loaded in the same way or something? I'll see if @peterhashair has the same issues with the github action tests runner, after that we can discuss again.

@peterhashair
Copy link
Contributor

peterhashair commented Aug 22, 2022

merge this with GitHub Action tests here #19659 @sgiehl seems like the Github Action doesn't have the UI failed, but not too sure if that's right.

@github-actions github-actions bot closed this Aug 26, 2022
@github-actions github-actions bot deleted the submodules branch August 26, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants