[Vue] fix back button to dashboard #19631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wik-dashboard element is present. the element no longer exists in 4.x-dev, so the hack does not actually do anything now
diosmosis
added
Needs Review
sgiehl
approved these changes
Aug 16, 2022
justinvelluppillai
added
the
not-in-changelog
bx80
pushed a commit
that referenced
this pull request
Nov 25, 2022
…wik-dashboard element is present. the element no longer exists in 4.x-dev, so the hack does not actually do anything now (#19631)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There was an optimization in 4.x-dev that manually loaded the dashboard if changing the page to a dashboard and the piwik-dashboard element was present on the page. During the migration to Vue, this was changed to always apply the optimization even if the piwik-dashboard element is not present (the bug). This causes a bug where the dashboard does not load when going back to it (or when loading the page explicitly after it has been loaded).
To reproduce:
This PR fixes the issue by removing the optimization. I verified on 4.x-dev, the piwik-dashboard element simply isn't on the page at the same time anymore, so whatever hacky code this was before is not actually used now.
Review