Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pseudolocalization #19630

Draft
wants to merge 2 commits into
base: 5.x-dev
Choose a base branch
from
Draft

Pseudolocalization #19630

wants to merge 2 commits into from

Conversation

Findus23
Copy link
Member

Inspired by https://netflixtechblog.com/pseudo-localization-netflix-12fff76fbcbe and others.
I think this helps a lot during testing. Unlike the "dev" language it is not completely unreadable and one can test features with it. Untranslated text immediately sticks out and issues with non-ASCII character should be more noticable than with English text.

Expanding the text by a factor (e.g. by duplicating every chacter with an n% chance) could also be added.

This is just a rough draft to show that the idea works. Of course it should become its separate language from the existing "dev".

grafik

Review

@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Aug 29, 2022
@sgiehl
Copy link
Member

sgiehl commented Sep 5, 2022

I like the idea. And we could even use it as replacement for the development language. That one is kind of useless, as it breaks most things due to missing placeholders.
Pushed a commit to avoid replacing stuff of the intl plugin, as otherwise the format strings are replaced and can be used anymore for number and date formatting...

@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Sep 6, 2022
@Findus23
Copy link
Member Author

Findus23 commented Sep 6, 2022

That one is kind of useless, as it breaks most things due to missing placeholders.

That's true, but I feel like it has another very useful use case: You can very quickly find out how a translation string you see anywhere in Matomo is called. Especially for non-technical users and translators. So I would leave it as a separate thing.

I think there is just one larger issue with this code: It breaks HTML inside translation strings (which I think isn't that rare). And I can't think of a simple solution for that (I think laravel uses a full HTML parser with allowed attributes that get modified to solve the issue).

And semi-related, it would also be nice if we had a way to increase the length of strings to simulate (very often German) strings overflowing.

@sgiehl
Copy link
Member

sgiehl commented Sep 7, 2022

That's true, but I feel like it has another very useful use case: You can very quickly find out how a translation string you see anywhere in Matomo is called. Especially for non-technical users and translators. So I would leave it as a separate thing.

Even for that case it would need to be improved. The problem is, that all number formatting and date formatting won't work correctly anymore and in some places it might even cause php or javascript errors due to missing placeholders.
I actually never used it in the last years.

@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Sep 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Nov 4, 2022
@sgiehl sgiehl changed the base branch from 4.x-dev to 5.x-dev March 16, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale for long The label used by the Close Stale Issues action Stale The label used by the Close Stale Issues action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants