@Findus23 opened this Pull Request on August 14th 2022 Member

Description:

I am not sure if this broke with my changes and the weblate migration or before, but I can't see any place in getAvailableLanguages() dev is added to the list.

Review

@justinvelluppillai commented on August 14th 2022 Member

It looks like you could otherwise leave that code as it was and just add "dev" to global config file, then that function would remove it for prod installs (though it would be incorrectly named, should be disableDevelopmentLanguageInProdEnvironment).

Is it possible it was previously just added by developers in config, and this change now means it is added automatically when you've enabled development mode? It might also need some documentation update to avoid future confusion.

@Findus23 commented on August 15th 2022 Member

@justinvelluppillai You are right that seems a lot simpler (and I guess I lost that entry with #17930). So we could just add the entry for all users as it will be ignored for non-development anyway.

@github-actions[bot] commented on September 1st 2022 Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@sgiehl commented on September 2nd 2022 Member

I think it's actually better to only add the language in the code if development mode is enabled, rather than adding dev to the config file. Otherwise dev would be shown as configured language in the configuration screen, which might look weird in a production instance, as it's not even a valid language code.

@justinvelluppillai commented on September 4th 2022 Member

Yep seems like a good approach to me.

This Pull Request was closed on September 5th 2022
Powered by GitHub Issue Mirror