Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use materializecss/materialize instead of Dogfalo/materialize #19622

Merged
merged 17 commits into from Mar 28, 2023
Merged

Use materializecss/materialize instead of Dogfalo/materialize #19622

merged 17 commits into from Mar 28, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 12, 2022

Description:

fixes #16368

Review

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 12, 2022
@sgiehl sgiehl added this to the 5.0.0 milestone Aug 12, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Sep 10, 2022
@sgiehl

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Sep 16, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Oct 1, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Nov 13, 2022
@Findus23

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot removed Stale for long The label used by the Close Stale Issues action Stale The label used by the Close Stale Issues action labels Nov 26, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Dec 14, 2022
@mattab mattab added the 5.0.0 label Jan 4, 2023
@sgiehl sgiehl force-pushed the materializeupdate branch 2 times, most recently from 9dc4e7e to b3b8fa2 Compare January 23, 2023 15:14
@sgiehl sgiehl force-pushed the materializeupdate branch 6 times, most recently from a95d7af to 0c51d30 Compare February 9, 2023 16:37
@sgiehl sgiehl force-pushed the materializeupdate branch 2 times, most recently from 1a42673 to 45f4ca9 Compare February 17, 2023 13:40
@sgiehl sgiehl removed the Stale The label used by the Close Stale Issues action label Mar 16, 2023
@sgiehl sgiehl marked this pull request as ready for review March 16, 2023 15:19
@sgiehl sgiehl force-pushed the materializeupdate branch 2 times, most recently from b3888f1 to cde0a2a Compare March 17, 2023 15:24
@sgiehl sgiehl added the Needs Review PRs that need a code review label Mar 17, 2023
@sgiehl sgiehl requested a review from bx80 March 22, 2023 09:06
bx80
bx80 approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also done some manual testing to check for any obvious UI layout breakages, I can't see any issues 👍

@sgiehl sgiehl merged commit aea8f07 into 5.x-dev Mar 28, 2023
16 of 19 checks passed
@sgiehl sgiehl deleted the materializeupdate branch March 28, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bx80 bx80 bx80 approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Keep MaterializeCSS up to date
4 participants
@sgiehl @Findus23 @bx80 @mattab