@sgiehl
Description:
fixes #16368
Review
- [ ] Functional review done
- [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- [ ] Security review done
- [ ] Wording review done
- [ ] Code review done
- [ ] Tests were added if useful/possible
- [ ] Reviewed for breaking changes
- [ ] Developer changelog updated if needed
- [ ] Documentation added if needed
- [ ] Existing documentation updated if needed
@github-actions[bot]
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.
So most parts seem to work as before again. The only thing that changed is the position of drop downs for selects. There had been changes to that component in MaterializeCSS, that prevent to have the dropdown being shown above the triggering element for selects. While that wouldn't be problematic I guess, they also added some code that should actually improve the positioning by looking for elements having overflow != visible. As we have overflow-y: scroll for the html element, that kind of breaks the positioning, but removing that would cause the scrollbar being hidden if not needed, causing the content width to change.
Not sure yet how to fix that...
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers
@Findus23
Just FYI: 1.2.0 was just released
https://github.com/materializecss/materialize/releases/tag/1.2.0
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.