Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for page goals visualization showing hits instead of visits #19618

Merged
merged 2 commits into from Aug 16, 2022
Merged

Fix for page goals visualization showing hits instead of visits #19618

merged 2 commits into from Aug 16, 2022

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Aug 11, 2022

Description:

The page goals visualization is incorrectly showing the number of 'simple page' views in the column labeled 'unique pageviews' as the wrong metric is being used, this PR changes it from nb_hits to nb_visits

Fixes #19615

Review

@bx80 bx80 self-assigned this Aug 11, 2022
@bx80 bx80 added the Bug For errors / faults / flaws / inconsistencies etc. label Aug 11, 2022
@bx80 bx80 added this to the 4.12.0 milestone Aug 11, 2022
sgiehl
sgiehl requested changes Aug 11, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bx80 The screenshot will need an update. Otherwise this looks good to merge.

@sgiehl sgiehl merged commit 4911a83 into 4.x-dev Aug 16, 2022
@sgiehl sgiehl deleted the m-19615-goals-uniq-col-fix branch August 16, 2022 07:22
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees

@bx80 bx80

Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

Fix for page goals visualization showing hits instead of visits
2 participants
@bx80 @sgiehl