Improve check for provider plugin #19614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
bx80
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
Test by renaming the provider plugin folder and confirming that the method will return false rather than throwing a fatal error.
- Functional review done
- Code review done
- No impact Security review done
- None apparent Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- No impact Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Not applicable Wording review done
- Not applicable Tests were added if useful/possible
- None Reviewed for breaking changes
- Not applicable Developer changelog updated if needed
- Not needed Documentation added if needed
- Existing documentation updated if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If, for some reason, the provider plugin is marked as installed, but not available in the file system, a fatal error might occur while tracking if the default geolocation provider is used.
Check if the class we are trying to use actually exists solves this issue.
refs #19602
Review