@AaronClifford opened this Pull Request on August 9th 2022

Description:

Bugfix: This should fix #19340, added unsanitizeInputValue around the username/password, I'm unable to test this locally so would require someone with an SMTP server available to them to test.

Review

@github-actions[bot] commented on September 3rd 2022 Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@sgiehl commented on September 8th 2022 Member

This change should actually not be needed at all. It true, that a & is stored as & in the config file. But that is actually on purpose, as all values stored in config are automatically encoded before they get saved and decoded when they are read.
See https://github.com/matomo-org/matomo/blob/95b9d8efc15d62c1a048a13f4e94e34e26de4cb5/core/Config/IniFileChain.php#L492-L530

This Pull Request was closed on September 8th 2022
Powered by GitHub Issue Mirror