Removes unused method Proxy\Controller::isPiwikUrl() #19610

sgiehl · 2022-08-08T15:42:16Z

Description:

While checking some other issue I cam across this unused method.

We used to use that method when we had a redirect method in the Proxy plugin to hide the referrer. With it's removal the method isn't used anymore.

matomo/plugins/Proxy/Controller.php

Lines 79 to 103 in e09383e

    
               public function redirect() 
        
               { 
        
                   $url = Common::getRequestVar('url', '', 'string', $_GET); 
        
                   if (!UrlHelper::isLookLikeUrl($url)) { 
        
                       die('Please check the &url= parameter: it should to be a valid URL'); 
        
                   } 
        
                   // validate referrer 
        
                   $referrer = Url::getReferrer(); 
        
                   if (empty($referrer) || !Url::isLocalUrl($referrer)) { 
        
                       die('Invalid Referrer detected - This means that your web browser is not sending the "Referrer URL" which is 
        
           				required to proceed with the redirect. Verify your browser settings and add-ons, to check why your browser 
        
           				 is not sending this referrer. 
        
           				<br/><br/>You can access the page at: ' . $url); 
        
                   } 
        
                   // mask visits to *.piwik.org 
        
                   if (!self::isPiwikUrl($url)) { 
        
                       Piwik::checkUserHasSomeViewAccess(); 
        
                   } 
        
                   Common::sendHeader('Content-Type: text/html; charset=utf-8'); 
        
                   echo '<html><head><meta http-equiv="refresh" content="0;url=' . $url . '" /></head></html>'; 
        
                   exit; 
        
               }

Review

bx80

Checked that the method isn't used anywhere in the codebase. Proxy unit test complete successfully.

Removes unused method Proxy\Controller:isPiwikUrl()

8013729

sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Aug 8, 2022

sgiehl added this to the 4.12.0 milestone Aug 8, 2022

sgiehl requested a review from bx80 August 8, 2022 15:42

bx80 approved these changes Aug 8, 2022

View reviewed changes

bx80 merged commit 48c458c into 4.x-dev Aug 8, 2022

bx80 deleted the unusedproxymethod branch August 8, 2022 21:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removes unused method Proxy\Controller::isPiwikUrl() #19610

Removes unused method Proxy\Controller::isPiwikUrl() #19610

sgiehl commented Aug 8, 2022

bx80 left a comment

	public function redirect()
	{
	$url = Common::getRequestVar('url', '', 'string', $_GET);
	if (!UrlHelper::isLookLikeUrl($url)) {
	die('Please check the &url= parameter: it should to be a valid URL');
	}
	// validate referrer
	$referrer = Url::getReferrer();
	if (empty($referrer) \|\| !Url::isLocalUrl($referrer)) {
	die('Invalid Referrer detected - This means that your web browser is not sending the "Referrer URL" which is
	required to proceed with the redirect. Verify your browser settings and add-ons, to check why your browser
	is not sending this referrer.

	<br/><br/>You can access the page at: ' . $url);
	}

	// mask visits to *.piwik.org
	if (!self::isPiwikUrl($url)) {
	Piwik::checkUserHasSomeViewAccess();
	}
	Common::sendHeader('Content-Type: text/html; charset=utf-8');
	echo '<html><head><meta http-equiv="refresh" content="0;url=' . $url . '" /></head></html>';

	exit;
	}

Removes unused method Proxy\Controller::isPiwikUrl() #19610

Removes unused method Proxy\Controller::isPiwikUrl() #19610

Conversation

sgiehl commented Aug 8, 2022

Description:

Review

bx80 left a comment

Choose a reason for hiding this comment