Use brute force detection for reset password action #19598
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In theory is would currently be possible to brute force the reset password token after a password reset was triggered.
Due to the length of the reset token it would take ages to guess the token correctly.
Performing the brute force detection upon a failed try won't hurt, but block the users after several tries and thus makes the process a bit more secure.
Note: I've avoided to also pass the provided login to the failed attempt, so only the IP address will be locked out.
Review