Do not accept invalid SSL certificates for requests to ASPSMS and Clockwork #19594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale
bx80
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Checked the new diagnostic item, reviewed code. Breakpoint tested the provider credit check since I don't have an SMS provider account configured. Everything works as expected 👍
- Functional review done
- Code review done
- Security review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Wording review done
- Tests were added if useful/possible
- Breaking change documented Reviewed for breaking changes
- Developer changelog updated if needed
- Documentation added if needed
- Existing documentation updated if needed
bx80
added a commit
that referenced
this pull request
Nov 25, 2022
…ckwork (#19594) * Do not accept invalid SSL certificates for requests to ASPSMS and Clockwork * Add changelog * Adds mobile messaging diagnostic * Update UI test screenshot * Fix test Co-authored-by: Ben <ben.burgess@innocraft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Review