Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all x axis labels for bar charts #19593

Draft
wants to merge 1 commit into
base: 4.x-dev
Choose a base branch
from
Draft

Show all x axis labels for bar charts #19593

wants to merge 1 commit into from

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 3, 2022

Description:

fixes #19592

Review

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 3, 2022
@sgiehl
Copy link
Member Author

sgiehl commented Aug 3, 2022

Note: Showing all labels can more easily cause overlapping labels if they are too long., like that is the case in out UI tests. Might be possible to fix this by making the labels multiline maybe:

@Starker3
Copy link
Contributor

Starker3 commented Aug 4, 2022

Could it maybe be a simple solution to just offset every 2nd label in the same way that we currently have every 2nd label hidden?
I.e. offset the label by one line height for every 2nd one.

@sgiehl
Copy link
Member Author

sgiehl commented Aug 4, 2022

@Starker3 might be a solution. But guess this looks ugly, when there actually would be enough space to display it on the same line.

@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Aug 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2022

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Stale for long The label used by the Close Stale Issues action Stale The label used by the Close Stale Issues action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bar Graph widget doesn't show all labels
2 participants