Require password confirmation when removing a site in UI #19591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
c: Security
|
Will update the screenshots once #19586 has been merged, to avoid merge conflicts. |
sgiehl
force-pushed
the
deletesiteconfirm
branch
from
6a6f089
to
aac3a71
Compare
bx80
approved these changes
Aug 5, 2022
There was a problem hiding this comment.
Just a minor text update needed, other than that this works well and looks ready to merge 👍
- Functional review done
- Code review done
- Security review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Wording review done
- Covered by existing UI tests (once updated) Tests were added if useful/possible
- Reviewed for breaking changes
- Change log has been updated Developer changelog updated if needed
- Not needed, change is self-explanatory Documentation added if needed
- Not needed. Existing documentation updated if needed
Co-authored-by: Ben Burgess <88810029+bx80@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As removing a site is an action that can't be undone, it's more secure to ask for a password confirmation in the UI.
This will prevent accidentally removing a site and will make it e.g. impossible to use an active session of someone else to remove sites without knowing the password.
Review