Fix placing series / series picker in charts #19588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Bug
bx80
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Nice spot @sgiehl, this one has been randomly failing for a while, great to have it finally tracked down 😃
I've updated the UI screenshot and the build is running, if the UI test passes then I guess this should be ready to merge.
- Functional review done
- Code review done
- No impact Security review done
- None apparent Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Not needed Wording review done
- Not needed Tests were added if useful/possible
- No breaking changes Reviewed for breaking changes
- Not neededDeveloper changelog updated if needed
- Not needed Documentation added if needed
- Not needed Existing documentation updated if needed
|
Great find 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I've investigate why one of our UI test is randomly failing all the time:
vs
The reason for this random failure actually turned out to be kind of a bug. The series in the chart needs to be placed more right, if a series picker icon is shown. While this is not the case for the chart on the UI test, there is a chart on the page that is loaded in the background of the popover. As the selector to adjust the placement was global, it also affected the one on the UI test. So the test used to fail depending on the loading speed of the reports in background.
Review