Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a config option to specify database error codes to ignore during updates #19578

Merged
merged 3 commits into from Aug 2, 2022
Merged

Added a config option to specify database error codes to ignore during updates #19578

merged 3 commits into from Aug 2, 2022

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Jul 28, 2022

Description:

Added a new config.ini.php option ignore_error_codes to specify database error codes that should always be ignored during database updates.

Fixes #19572

Review

@bx80 bx80 added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review labels Jul 28, 2022
@bx80 bx80 added this to the 4.12.0 milestone Jul 28, 2022
@bx80 bx80 self-assigned this Jul 28, 2022
sgiehl
sgiehl requested changes Jul 28, 2022
View reviewed changes
config/global.ini.php Outdated Show resolved Hide resolved
@bx80 @sgiehl
Update config/global.ini.php
888f167 
Co-authored-by: Stefan Giehl <stefan@matomo.org>
sgiehl
sgiehl requested changes Jul 29, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment. Otherwise I guess we need to create a new FAQ to explain in detail how this needs to be used to run Matomo on e.g. Planet Scale.

core/Updater/Migration/Db/Sql.php Outdated Show resolved Hide resolved
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jul 29, 2022
@bx80 @sgiehl
Update core/Updater/Migration/Db/Sql.php
3d1ed3f 
Co-authored-by: Stefan Giehl <stefan@matomo.org>
@bx80
Copy link
Contributor Author

bx80 commented Aug 1, 2022

Draft FAQ at https://matomo.org/?post_type=faq&p=56823&preview=true

sgiehl
sgiehl approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bx80 The FAQ looks fine for me, but guess we should mention somewhere that the config option only exists as of Matomo 4.12.
@justinvelluppillai would you mind reviewing the FAQ regarding wording & grammar.

@justinvelluppillai
Copy link
Contributor

@justinvelluppillai would you mind reviewing the FAQ regarding wording & grammar.

Looks great. Managed to find/fix a couple words, it's good to go grammatically now.

@justinvelluppillai justinvelluppillai merged commit 908ea17 into 4.x-dev Aug 2, 2022
@justinvelluppillai justinvelluppillai deleted the m-19572-ignore-errorcode-config branch August 2, 2022 09:43
@justinvelluppillai
Copy link
Contributor

I've merged this and published the FAQ.

@justinvelluppillai justinvelluppillai changed the title Config option to specify database error codes to ignore during updates Added a config option to specify database error codes to ignore during updates Sep 29, 2022
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees

@bx80 bx80

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

Add config option for database errors to ignore during updates
3 participants
@bx80 @justinvelluppillai @sgiehl