Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the sanitization of request parameters #19577

Merged
merged 3 commits into from Aug 2, 2022
Merged

Improve the sanitization of request parameters #19577

merged 3 commits into from Aug 2, 2022

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Jul 28, 2022

Description:

Minor improvement to sanitize request parameters by replacing \t tab characters with spaces

Review

@bx80 bx80 added the c: Tracking For issues related to getting tracking data into Matomo. label Jul 28, 2022
@bx80 bx80 added this to the 4.12.0 milestone Jul 28, 2022
@bx80 bx80 self-assigned this Jul 28, 2022
@bx80 bx80 added the Needs Review PRs that need a code review label Jul 28, 2022
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jul 29, 2022
@bx80 bx80 added the Needs Review PRs that need a code review label Aug 1, 2022
sgiehl
sgiehl requested changes Aug 1, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the comment is resolved, this one should be good to merge

core/DataTable/Renderer/Csv.php Outdated Show resolved Hide resolved
@sgiehl sgiehl removed Needs Review PRs that need a code review c: Tracking For issues related to getting tracking data into Matomo. labels Aug 1, 2022
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 2, 2022
@sgiehl sgiehl merged commit 60b5bf5 into 4.x-dev Aug 2, 2022
@sgiehl sgiehl deleted the improve-sanitize-params branch August 2, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees

@bx80 bx80

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bx80 @sgiehl