Fix the password length checks on invite User #19576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update password checks
bx80
suggested changes
Jul 28, 2022
There was a problem hiding this comment.
It would be great if we could have the acceptInvitation method call UsersManager::checkPassword instead of duplicating the same checks, as suggested in the issue description. There might be additional password requirements in the future, so having just one place that decides if a password is valid would be more future proof. checkPassword throws an exception instead of providing a return value, but acceptInvitation could catch the exception string and set it as the value of $error.
update passcheck
bx80
suggested changes
Jul 28, 2022
added 2 commits
July 29, 2022 11:46
simplify
update wording
sgiehl
reviewed
Jul 29, 2022
update event
sgiehl
approved these changes
Aug 1, 2022
justinvelluppillai
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes: #19573
update password checks
Review