New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Params name not matching, caused first website granted not working #19575
Conversation
update Param name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've recreated the issue prior to this fix, applied the fix and the functional issue is resolved.
I think it would be good to add a unit test where we call inviteUser
with specific userLogin
, email
, siteId
and expiryInDays
parameters value then read back the created user to assert that all the supplied parameters were applied as expected. This will protect against future regressions.
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- Wording review done
- Code review done
- Tests were added if useful/possible
- Reviewed for breaking changes
- Developer changelog updated if needed
- Documentation added if needed
- Existing documentation updated if needed
update invite User check, if initialIdSite is null throw error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken a look through the other API methods added by this PR and they all seem to have appropriate unit tests. It's now not possible to invite a user without explicitly specifying a site, either from the UI or via the API 👍
If the build tests all pass then this should be good to go.
update tests
remove another function
update tests
Our Team finally agree to throw an exception on InviteUser API when initSiteID is empty, but there is no change to addUser API. |
revert a tests
update screenshots
Description:
Fixes: #19574
This was caused by the param name, update it works now.
Review