Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] add isReportingPage() method to replace isAngularRenderingThePage() #19570

Merged
merged 2 commits into from Jul 26, 2022

Conversation

diosmosis
Copy link
Member

Description:

Already introduced in other Vue PRs and in use by plugin PRs. This is mainly in this additional PR so some plugin builds will pass.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 26, 2022
@diosmosis diosmosis added this to the 4.12.0 milestone Jul 26, 2022
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Jul 26, 2022
@sgiehl
Copy link
Member

sgiehl commented Jul 26, 2022

@diosmosis It seems for some reason the angular/vue js tests are failing on the PR. Can't see a reason why your changes might produce that, but maybe you can have a quick look.

@diosmosis
Copy link
Member Author

@sgiehl should be fixed

@sgiehl sgiehl merged commit a1bcde7 into 4.x-dev Jul 26, 2022
@sgiehl sgiehl deleted the vue-add-alternative-isAngularRenderingThePage branch July 26, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants