Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible notices / code improvements #19561

Merged
merged 3 commits into from Jul 25, 2022
Merged

Fix possible notices / code improvements #19561

merged 3 commits into from Jul 25, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 22, 2022 •
edited

Description:

Seems in some cases suppressing an error using @ does not work the same anymore on PHP 8.
As using @ should be avoided anyway, it makes sense to simply replace it.

fixes #19557
fixes #19556
fixes #19555

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jul 22, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Jul 22, 2022
peterhashair
peterhashair approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test report for different siteId, work as expected. I’ve looked through the code changes and they also seem good 👍

@sgiehl sgiehl merged commit 064f6db into 4.x-dev Jul 25, 2022
@sgiehl sgiehl deleted the fixnotices branch July 25, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.12.0
2 participants
@sgiehl @peterhashair