Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fatal error when generating the documentation #19553

Closed
mattmary opened this issue Jul 21, 2022 · 1 comment · Fixed by #19567
Closed

Fatal error when generating the documentation #19553

mattmary opened this issue Jul 21, 2022 · 1 comment · Fixed by #19567
Assignees
@sgiehl
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.12.0

Comments

@mattmary
Copy link
Contributor

PHP Fatal error: Declaration of Piwik\Plugins\PagePerformance\JqplotDataGenerator\Chart::setAxisYValues(&$values, $seriesLabels = null) must be compatible with Piwik\Plugins\CoreVisualizations\JqplotDataGenerator\Chart::setAxisYValues(&$values, $seriesMetadata = null, ?array $seriesUnits = null) in piwik/plugins/PagePerformance/JqplotDataGenerator/Chart.php on line 55

Expected Behavior

No Fatal error.

Current Behavior

I get this fatal error:

PHP Fatal error: Declaration of Piwik\Plugins\PagePerformance\JqplotDataGenerator\Chart::setAxisYValues(&$values, $seriesLabels = null) must be compatible with Piwik\Plugins\CoreVisualizations\JqplotDataGenerator\Chart::setAxisYValues(&$values, $seriesMetadata = null, ?array $seriesUnits = null) in piwik/plugins/PagePerformance/JqplotDataGenerator/Chart.php on line 55

Steps to Reproduce (for Bugs)

  1. git clone git@github.com:matomo-org/developer-documentation.git
  2. git checkout php8
  3. ./generate.sh

Your Environment

  • Matomo Version: branch 4.x-dev
  • PHP Version: 8.0.21
  • Server Operating System: Linux (Ubuntu)
  • Additionally installed plugins: none
@mattmary mattmary added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Jul 21, 2022
@bx80 bx80 added Regression Indicates a feature used to work in a certain way but it no longer does even though it should. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Jul 21, 2022
@bx80
Copy link
Contributor

bx80 commented Jul 21, 2022

The method signature of setAxisYValues in plugins\CoreVisualizations/JqplotDataGenerator/Chart was updated with an extra parameter as part of #19353, the PagePerformance plugin overrides this method and already had a slightly different method signature ($seriesLabels vs $seriesMetaData), so the additional parameter has now made them incompatible.

The method signature in PagePerformance needs to be updated to match core.

@bx80 bx80 added this to the 4.12.0 milestone Jul 21, 2022
@mattmary mattmary mentioned this issue Jul 25, 2022
Merged
@sgiehl sgiehl self-assigned this Jul 25, 2022
@sgiehl sgiehl mentioned this issue Jul 25, 2022
Merged
11 tasks
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging a pull request may close this issue.

Remove special handling for setAxisYValues in page performance charts matomo-org/matomo
4 participants
@justinvelluppillai @sgiehl @mattmary @bx80