Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve translation source string #19552

Merged
merged 1 commit into from Jul 25, 2022
Merged

Improve translation source string #19552

merged 1 commit into from Jul 25, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 21, 2022

Description:

Placing single words in translations isn't something we should do. That makes it hard for translators to know how to translate it correctly, as they don't know what's placed there.

It's better two have two separate translations instead of one in that case.

fixes #19551

Review

@sgiehl sgiehl added Needs Review PRs that need a code review c: i18n For issues around internationalisation and localisation. labels Jul 21, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Jul 21, 2022
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sgiehl sgiehl merged commit 5052df9 into 4.x-dev Jul 25, 2022
@sgiehl sgiehl deleted the improvesource branch July 25, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: i18n For issues around internationalisation and localisation. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to enter plugin license key with Japanese language set
2 participants