Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to enter plugin license key with Japanese language set #19551

Closed
Starker3 opened this issue Jul 20, 2022 · 2 comments · Fixed by #19552
Closed

Unable to enter plugin license key with Japanese language set #19551

Starker3 opened this issue Jul 20, 2022 · 2 comments · Fixed by #19552
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: i18n For issues around internationalisation and localisation.
Milestone
4.12.0

Comments

@Starker3
Copy link
Contributor

When a users language is set to Japanese, it's not possible to click on the input box to enter a license key for plugins.
For example:
image
It seems to show that the cursor is over the link to upload a plugin, which when clicked results in this popup when plugin uploads are not enabled:
image
When plugin uploads are enabled, it shows the plugin upload overlay:
image

Clicking anywhere in the highlighted area brings the overlay to upload a plugin:
image

I've tested this on a few other languages (Arabic, Korean, Simplified/Traditional Chinese) and couldn't reproduce it there, so its possibly just the Japanese translation where this is happening.
@Starker3 Starker3 added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Jul 20, 2022
@sgiehl
Copy link
Member

sgiehl commented Jul 21, 2022

Guess there might be a link tag not being closed correctly. Will check that quickly

@sgiehl sgiehl self-assigned this Jul 21, 2022
@sgiehl sgiehl added c: i18n For issues around internationalisation and localisation. Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Jul 21, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Jul 21, 2022
@sgiehl
Copy link
Member

sgiehl commented Jul 21, 2022

This is an issue with the translation. The english source string might be a bit hard to understand, as there are some words placed within and a link. The order of placeholders for Japanese isn't correct, causing the open link tag being placed in the end.
I'll create a PR to split the source string, so no additional words are placed. Hopefully that makes it easier to translate the string.

@sgiehl sgiehl mentioned this issue Jul 21, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc. c: i18n For issues around internationalisation and localisation.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging a pull request may close this issue.

Improve translation source string matomo-org/matomo
2 participants
@sgiehl @Starker3