Default to HTTPS request #19549
Closed
Default to HTTPS request #19549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default Matomo request to http
update checks
Co-authored-by: Justin Velluppillai <justin@innocraft.com>
update lang and links
update phpcs
update checks
Co-authored-by: Stefan Giehl <stefan@matomo.org>
revert code style changes
update checks and changes
update screenshots
Co-authored-by: Justin Velluppillai <justin@innocraft.com>
update link
update https to http as default
This reverts commit e2ea4f1.
update lang
peterhashair
added
the
Do not close
Merged
11 tasks
# Conflicts: # plugins/CoreUpdater/Diagnostic/HttpsUpdateCheck.php # plugins/Installation/lang/en.json # plugins/Marketplace/Api/Client.php # plugins/Marketplace/config/config.php # tests/UI/expected-screenshots/UIIntegrationTest_admin_diagnostics_configfile.png
justinvelluppillai
changed the title
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale
|
Close this, will re-create |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Description:
Please do not merge this
Fixes: #19081
Final changes.
Update HTTPS security check, when the client is using HTTP throw a warning on diagnostic
Ref Here: https://github.com/matomo-org/matomo-security/issues/195
Review