Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check for raw data availability #19547

Merged
merged 4 commits into from Jul 20, 2022
Merged

Fix check for raw data availability #19547

merged 4 commits into from Jul 20, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 19, 2022

Description:

While checking #19539 I found this obvious bug. The handling if raw data is available seems to have worked with the wrong response.

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Jul 19, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Jul 19, 2022
@sgiehl sgiehl requested a review from diosmosis July 19, 2022 14:31
@sgiehl sgiehl mentioned this pull request Jul 19, 2022
Open
Merge branch '4.x-dev' into rawdatamessage
e9fd2de 
# Conflicts:
#	plugins/CoreHome/vue/dist/CoreHome.umd.min.js
@sgiehl sgiehl merged commit 45905c0 into 4.x-dev Jul 20, 2022
@sgiehl sgiehl deleted the rawdatamessage branch July 20, 2022 12:38
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis left review comments

@peterhashair peterhashair peterhashair approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @diosmosis @peterhashair