Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vendor lib szymach/c-pchart to latest version #19546

Closed
sgiehl opened this issue Jul 19, 2022 · 4 comments · Fixed by #19604
Closed

Update vendor lib szymach/c-pchart to latest version #19546

sgiehl opened this issue Jul 19, 2022 · 4 comments · Fixed by #19604
Assignees
@sgiehl
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
4.12.0

Comments

@sgiehl
Copy link
Member

sgiehl commented Jul 19, 2022

Summary

The vendor lib szymach/c-pchart released a new update 3.0.14.
Using this new version the images generated by ImageGraph plugin changed and are looking a bit misplaced. Some numbers are even placed partially outside the viewport.

It fixes a couple of PHP 8.1 deprecation notices by casting a couple of variables to integer. Maybe this causes the numbers to be calculated a bit differently.

We need to investigate if we can provide a fix for the lib, so our graphs look better again, or if we need to adjust our graphs instead.

follow-up to #19537
@sgiehl sgiehl added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs priority decision This issue may need to be added to the current milestone by Product Manager labels Jul 19, 2022
@sgiehl sgiehl added this to the For Prioritization milestone Jul 19, 2022
@justinvelluppillai
Copy link
Contributor

@sgiehl great if you can spend a couple hours at most looking into this and if it's an easy fix we can complete it in the 4.12 milestone.

@justinvelluppillai justinvelluppillai added Regression Indicates a feature used to work in a certain way but it no longer does even though it should. and removed Needs priority decision This issue may need to be added to the current milestone by Product Manager labels Aug 5, 2022
@sgiehl
Copy link
Member Author

sgiehl commented Aug 5, 2022

created a PR upstream. Let's see if that will get merged... szymach/c-pchart#81

@sgiehl sgiehl self-assigned this Aug 5, 2022
@justinvelluppillai
Copy link
Contributor

@sgiehl looks like it's merged already 👍🏽

@sgiehl
Copy link
Member Author

sgiehl commented Aug 7, 2022

Yep. Will create a PR to update the lib then.

@sgiehl sgiehl mentioned this issue Aug 7, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging a pull request may close this issue.

update szymach/c-pchart matomo-org/matomo
2 participants
@justinvelluppillai @sgiehl