@futureweb opened this Pull Request on July 14th 2022 Contributor

Description:

Implement cookie expire time - forgetConsentGiven Feature Request #19530

Review

@sgiehl commented on July 19th 2022 Member

Hi @futureweb Thanks for creating this PR.
Changes to piwik.js require the minified tracker files to be rebuilt. See https://github.com/matomo-org/matomo/blob/4.x-dev/js/README.md#L32 for instructions how to update such files.

@futureweb commented on July 19th 2022 Contributor

Hi @futureweb Thanks for creating this PR. Changes to piwik.js require the minified tracker files to be rebuilt. See https://github.com/matomo-org/matomo/blob/4.x-dev/js/README.md#L32 for instructions how to update such files.

Hi @sgiehl - thx for the info, was my first commit within the .js scope ... ;-)
Have updated the minified tracker files as advised.

@sgiehl commented on July 20th 2022 Member

@futureweb Thanks for that. Seems you missed to also update the file /piwik.js

@futureweb commented on July 20th 2022 Contributor

@sgiehl - darn ... never noticed there are already so much redundant versions of the JS since the Name-Switch ... ^^ ... hope I got em all now 😅

This Pull Request was closed on July 21st 2022
Powered by GitHub Issue Mirror