Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cookie expire time - forgetConsentGiven #19532

Merged
merged 6 commits into from Jul 21, 2022

Conversation

futureweb
Copy link
Contributor

Description:

Implement cookie expire time - forgetConsentGiven Feature Request #19530

Review

@sgiehl
Copy link
Member

sgiehl commented Jul 19, 2022

Hi @futureweb Thanks for creating this PR.
Changes to piwik.js require the minified tracker files to be rebuilt. See https://github.com/matomo-org/matomo/blob/4.x-dev/js/README.md#L32 for instructions how to update such files.

@futureweb
Copy link
Contributor Author

Hi @futureweb Thanks for creating this PR. Changes to piwik.js require the minified tracker files to be rebuilt. See https://github.com/matomo-org/matomo/blob/4.x-dev/js/README.md#L32 for instructions how to update such files.

Hi @sgiehl - thx for the info, was my first commit within the .js scope ... ;-)
Have updated the minified tracker files as advised.

@sgiehl
Copy link
Member

sgiehl commented Jul 20, 2022

@futureweb Thanks for that. Seems you missed to also update the file /piwik.js

@futureweb
Copy link
Contributor Author

@sgiehl - darn ... never noticed there are already so much redundant versions of the JS since the Name-Switch ... ^^ ... hope I got em all now 😅

js/piwik.js Show resolved Hide resolved
@futureweb futureweb requested a review from sgiehl July 20, 2022 13:15
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now 🎉
Thanks for the contribution @futureweb

@sgiehl sgiehl added this to the 4.12.0 milestone Jul 21, 2022
@sgiehl sgiehl merged commit 06b431b into matomo-org:4.x-dev Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom cookie expiry date for optUserOut() & forgetUserOptOut() functions
2 participants