Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable ErrorHandler #19531

Open
ulcuber opened this issue Jul 14, 2022 · 1 comment
Open

Configurable ErrorHandler #19531

ulcuber opened this issue Jul 14, 2022 · 1 comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
For Prioritization

Comments

@ulcuber
Copy link
Contributor

ulcuber commented Jul 14, 2022

  1. Add ability to throw on warning/notice
  2. Maybe add filters for exception logging

Summary

  1. Currently Notice - Undefined index does not stop execution but it could lead to bugs silently logging such cases.

  2. For example, laravel do not logs validation/authorization exceptions using internalDontReport:
    https://github.com/laravel/framework/blob/9.x/src/Illuminate/Foundation/Exceptions/Handler.php
@ulcuber ulcuber added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Jul 14, 2022
@peterhashair peterhashair added this to the For Prioritization milestone Jul 18, 2022
@sgiehl
Copy link
Member

sgiehl commented Jul 18, 2022

Hi @ulcuber
Thanks for the suggestions. In general I would agree that it might be nice to have a possibility to configure this. But actually that would only help for development. This couldn't be turned on in productive mode, as our code base is quite old and there might be some notices that had been "ignored" on purpose. We are always trying to fix those when we see them, but I'm not able to say if stopping the executing for notices might not even break some parts of Matomo.

Personally I'm always having a log tail running while developing, so I'm able to see if a notice occurs somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
For Prioritization
Development

No branches or pull requests
3 participants
@sgiehl @peterhashair @ulcuber