Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible javascript error on marketplace #19529

Merged
merged 1 commit into from Jul 15, 2022
Merged

Fix possible javascript error on marketplace #19529

merged 1 commit into from Jul 15, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 14, 2022

Description:

When searching on the marketplace and having no results this currently throws a javascript error and the page is fully unusable:

image

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Jul 14, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Jul 14, 2022
@sgiehl sgiehl requested a review from diosmosis July 14, 2022 07:56
@sgiehl sgiehl mentioned this pull request Jul 14, 2022
Closed
@sgiehl sgiehl merged commit 835ba7d into 4.x-dev Jul 15, 2022
@sgiehl sgiehl deleted the fixmarketplacevue branch July 15, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis