@peterhashair opened this Pull Request on July 13th 2022 Contributor

Description:

Fixes: #19515
revert refresh button

Review

@sgiehl commented on July 18th 2022 Member

I would personally at least keep the keyboard shortcut. But that might be not a decision I'm allowed to make.

@tsteur commented on July 18th 2022 Member

Keyboard shortcut be good to have indeed

@sgiehl commented on July 20th 2022 Member

@justinvelluppillai should this one go into 4.11 ? Otherwise the button would be added with 4.11. and removed again with 4.12. Which imho wouldn't be good.

@justinvelluppillai commented on July 21st 2022 Member

@sgiehl yes that is the intent here. @peterhashair this would need to be rebased of the next_release branch now.

@sgiehl commented on July 21st 2022 Member

@peterhashair I have rebased the branch. Might be possible some of the screenshots might need another update due to the change.
Also I had added a couple of comments regarding still required translations in my last review. You have marked them as resolved, but haven't pushed any further update. It would be helpful to only mark review comments as resolved if you

  • either pushed something that really fixes it
  • or add a comment that really resolves it (like answering a question)

Or what might be an even better handling: Give feedback on each comment like "I've pushed a fix", answer questions or ask a question if it wasn't clear. Afterwards the reviewer can resolve the comments himself in the next review round.

@peterhashair commented on July 25th 2022 Contributor

@sgiehl will pay more attention to the screenshots updates from now on 👍. Updated it.

This Pull Request was closed on July 25th 2022
Powered by GitHub Issue Mirror