Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Language depends on user language. #19520

Closed
ClientCrash opened this issue Jul 12, 2022 · 1 comment
Closed

API Language depends on user language. #19520

ClientCrash opened this issue Jul 12, 2022 · 1 comment
Labels
answered For when a question was asked and we referred to forum or answered it.

Comments

@ClientCrash
Copy link

ClientCrash commented Jul 12, 2022 •
edited

Expected Behavior

API Language should never change. This breaks systems.

Current Behavior

If the user has a different language, for example German, the language of API responses changes.

Possible Solution

It should be completely removed of if some people depend on it it should be a toggle that is off by default.

Context

The API being dependent on users and their language settings created issues in our production environment.

Your Environment

  • Matomo Version: 3
@ClientCrash ClientCrash added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Jul 12, 2022
@bx80
Copy link
Contributor

bx80 commented Jul 13, 2022

Hi @ClientCrash, thanks for reaching out. Sorry to hear that this behavior caused an issue for you.

The API has an optional language parameter, this can be set on API requests so the same language is always used to give consistent responses.

Changing the API to ignore users language by default could cause problems for existing API usage. We also can't assume that every user understands English, it seems reasonable that if a user has already indicated that they want to use Matomo in a specific language then API responses should by default be served in that language and not a different language that the user might not be able to comprehend. I hope that makes sense 🙂

@bx80 bx80 added answered For when a question was asked and we referred to forum or answered it. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Jul 13, 2022
@bx80 bx80 closed this as completed Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ClientCrash @bx80