Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude paypal as referrer in javascript tracker #19517

Merged
merged 1 commit into from Jul 29, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 12, 2022

Description:

This is a quick and dirty fix for Matomo 4.11. as requested by @mattab
@justinvelluppillai feel free to discuss with him or @tsteur if we shall merge this for 4.11. or not.

The change needs to be reverted after 4.11. was released, as a proper fix is included in #19516 for Matomo 4.12 (using the new referrer exclusion feature)

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jul 12, 2022
@sgiehl sgiehl added this to the 4.11.0 milestone Jul 12, 2022
@justinvelluppillai
Copy link
Contributor

@sgiehl can we just merge the other PR #19156 in 4.11 instead of this one?

@justinvelluppillai justinvelluppillai removed the Needs Review PRs that need a code review label Jul 14, 2022
@justinvelluppillai
Copy link
Contributor

To be reverted after 4.11 release

@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 29, 2022
@justinvelluppillai justinvelluppillai merged commit c7294b3 into next_release Jul 29, 2022
@justinvelluppillai justinvelluppillai deleted the paypalfix branch July 29, 2022 02:17
sgiehl added a commit that referenced this pull request Jul 29, 2022
sgiehl added a commit that referenced this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale The label used by the Close Stale Issues action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants