Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude .paypal.com as referrer by default #19516

Merged
merged 2 commits into from Jul 14, 2022
Merged

Exclude .paypal.com as referrer by default #19516

merged 2 commits into from Jul 14, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 12, 2022

Description:

As requested by @mattab

Adds .paypal.com to the default list of excluded referrers in javascript tracker.
If someone calls setExcludedReferrers in his tracking code, this will be overwritten.

Note: This will not exclude PayPal as referrer on PHP site by default. But that shouldn't be needed if the javascript tracker doesn't send the referrer anymore.

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jul 12, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Jul 12, 2022
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked code, all the tests pass, looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants