New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] make all scripts load via defer #19514
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rg/matomo into vue-remove-angularjs-MultiSites
…-CoreHome-CorePluginsAdmin
…angularjs-CoreHome-CorePluginsAdmin
…/matomo into vue-remove-angularjs-Morpheus
…angularjs-MobileMessaging
…omo-org/matomo into vue-remove-angularjs-MobileMessaging
…rjs-CoreHome-CorePluginsAdmin
…org/matomo into vue-remove-angularjs-Marketplace
…omo-org/matomo into vue-remove-angularjs-MobileMessaging
…ngularjs-CoreHome-CorePluginsAdmin
…tomo into vue-remove-angularjs-Login
…omo into vue-remove-angularjs-Live
…oreHome-CorePluginsAdmin
…tomo-org/matomo into vue-remove-angularjs-LanguagesManager
…e-remove-angularjs-final
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
github-actions
bot
added
the
Stale
The label used by the Close Stale Issues action
label
Jul 27, 2022
…e-remove-angularjs-final
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale for long
The label used by the Close Stale Issues action
label
Sep 8, 2022
sgiehl
added
Do not close
PRs with this label won't be marked as stale by the Close Stale Issues action
and removed
5.0.0
Stale
The label used by the Close Stale Issues action
Stale for long
The label used by the Close Stale Issues action
labels
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is based off #19502.
Fixes #18982.
Changes:
defer
attribute.$(document).ready(
in inline<script>
s w/window.addEventListener('DOMContentLoaded',
(or just replaced some).development:compute-js-asset-size
command, also printing total size of vanilla JS (non-Vue code) by plugin.CoreHome.DataTable
directive to initialize datatables instead of inline scripts. Similarly added LegacyUIControl directive for _uiControl.twig files, and similar directives for UserCountryMap widgets.UserCountryMapLegacyModule
to house vanilla JS objects related to realtime/visitor map.UserCountryMap
shouldn't be used since it is also the name of a plugin w/ Vue code.Review