Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] make all scripts load via defer #19514

Closed
wants to merge 416 commits into from

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Jul 12, 2022

Description:

This PR is based off #19502.

Fixes #18982.

Changes:

  • All JS assets are included w/ the defer attribute.
  • wrap uses of $(document).ready( in inline <script>s w/ window.addEventListener('DOMContentLoaded', (or just replaced some).
  • In development:compute-js-asset-size command, also printing total size of vanilla JS (non-Vue code) by plugin.
  • Introduce CoreHome.DataTable directive to initialize datatables instead of inline scripts. Similarly added LegacyUIControl directive for _uiControl.twig files, and similar directives for UserCountryMap widgets.
  • Fix some exception messages in piwikHelper.js (messages referencing vue-entry changed to vue-directive).
  • Introduce UserCountryMapLegacyModule to house vanilla JS objects related to realtime/visitor map. UserCountryMap shouldn't be used since it is also the name of a plugin w/ Vue code.

Review

…rg/matomo into vue-remove-angularjs-MultiSites
…omo-org/matomo into vue-remove-angularjs-MobileMessaging
…org/matomo into vue-remove-angularjs-Marketplace
…omo-org/matomo into vue-remove-angularjs-MobileMessaging
…tomo-org/matomo into vue-remove-angularjs-LanguagesManager
@diosmosis diosmosis added this to the 5.0.0 milestone Jul 12, 2022
@diosmosis diosmosis marked this pull request as draft July 12, 2022 05:04
@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Sep 8, 2022
@mattab mattab added the 5.0.0 label Jan 4, 2023
@sgiehl sgiehl modified the milestones: 5.0.0, 6.0.0 Jun 20, 2023
@sgiehl sgiehl added Do not close PRs with this label won't be marked as stale by the Close Stale Issues action and removed 5.0.0 Stale The label used by the Close Stale Issues action Stale for long The label used by the Close Stale Issues action labels Jun 20, 2023
@michalkleiner michalkleiner deleted the vue-final-performance-testing branch October 27, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Vue] Performance improvement: make getCoreJs/getNonCoreJs load via defer
4 participants