Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Keyword Search #19509

Closed
peterhashair opened this issue Jul 11, 2022 · 6 comments
Closed

User Keyword Search #19509

peterhashair opened this issue Jul 11, 2022 · 6 comments
Assignees
@diosmosis
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.12.0

Comments

@peterhashair
Copy link
Contributor

peterhashair commented Jul 11, 2022 •
edited

When I am writing the FAQ, I found the keyword search under user manage is quite bugged. I guess maybe we need to add a debounce on the key-up events.

Manage.access.-.Administration.-.Matomo.mp4

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for Bugs)

Context

Your Environment

  • Matomo Version: 4.11
  • PHP Version: 8.0
  • Server Operating System:
  • Additionally installed plugins:
  • Browser:
  • Operating System:
@peterhashair peterhashair added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. Needs priority decision This issue may need to be added to the current milestone by Product Manager and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Jul 11, 2022
@sgiehl sgiehl added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Jul 11, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Jul 11, 2022
@sgiehl sgiehl removed the Needs priority decision This issue may need to be added to the current milestone by Product Manager label Jul 11, 2022
@sgiehl
Copy link
Member

sgiehl commented Jul 11, 2022

probably a vue regression. ping @diosmosis

@diosmosis
Copy link
Member

A regression caused by #19375, the nextTick() is not enough to execute the code after the property emit finishes. Not sure yet what a fix would be.

@sgiehl
Copy link
Member

sgiehl commented Jul 11, 2022

@diosmosis would that be fixed with removing angular js? Or would that issue remain?

@diosmosis
Copy link
Member

@sgiehl it will remain, it seems to be a Vue reactivity issue.

@diosmosis diosmosis mentioned this issue Jul 11, 2022
Merged
11 tasks
@sgiehl
Copy link
Member

sgiehl commented Jul 25, 2022

This one seems to be fixed meanwhile. At least it works for me on latest 4.x-dev.
@peterhashair Are you able to confirm that it works for you as well?

@peterhashair
Copy link
Contributor Author

@sgiehl yes it works

@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.12.0
Development

No branches or pull requests
4 participants
@diosmosis @justinvelluppillai @sgiehl @peterhashair