Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with map tooltip and accented letters #19500

Closed
paolobenve opened this issue Jul 9, 2022 · 3 comments · Fixed by #19508
Closed

problem with map tooltip and accented letters #19500

paolobenve opened this issue Jul 9, 2022 · 3 comments · Fixed by #19508
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@paolobenve
Copy link

paolobenve commented Jul 9, 2022

A cuban province, Camagüey, appears as Camagey in the map tooltip. Looks like a utf8 issue

Matomo version: 4.10.1

camagey 1

@paolobenve paolobenve added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Jul 9, 2022
@bx80
Copy link
Contributor

bx80 commented Jul 10, 2022

Hi @paolobenve, thanks for spotting this. I've created a PR to correct the name

@bx80 bx80 added this to the 4.12.0 milestone Jul 10, 2022
@bx80 bx80 added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Jul 10, 2022
@paolobenve
Copy link
Author

paolobenve commented Jul 11, 2022

is it not a problem with a cuban province, it's a problem with utf8 non-ascii text: see other cuban provinces with accented letters: Pinar del Río, Ciego de Ávila, Guantánamo.

I suppose it's a problem with all the tooltips which involve accented letters

@bx80
Copy link
Contributor

bx80 commented Jul 11, 2022

@paolobenve My mistake, I thought it was just an issue with a single province name. You are correct - accented characters in many (but not all) map names are missing, this seems to have been a UTF-8 issue with the initial map SVG files that were generated sometime before 2013. There have been various fixes since to correct individual countries that have places with accented characters .

I expect at some point the visitor map code will receive a major overhaul as it uses libraries that are no longer maintained, but in the meantime I'll can at least adjust my fix to correct all Cuban province names.

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants