New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transitions plugin language reworked #19497
Transitions plugin language reworked #19497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions, otherwise looks good.
plugins/Transitions/lang/en.json
Outdated
"AvailableInOtherReports2": "Simply hover a row in any of these reports and click on the transition icon %s to launch it.", | ||
"FromCampaigns": "From Campaigns", | ||
"FromPreviousPages": "From Internal Pages", | ||
"AvailableInOtherReports2": "Simply hover a row in any of these reports and click on the transition icon \"%s\" to launch it.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The placeholder will be replaced with the icon itself, so guess there's no need to place it within ", right?
"AvailableInOtherReports2": "Simply hover a row in any of these reports and click on the transition icon \"%s\" to launch it.", | |
"AvailableInOtherReports2": "Simply hover a row in any of these reports and click on the transition icon %s to launch it.", |
Co-authored-by: Stefan Giehl <stefan@matomo.org>
* Live plugin language reworked (#19438) * Live plugin language reworked * Sentence casing Co-authored-by: Stefan Giehl <stefan@matomo.org> * Visited earlier, subcategories * Reverted to "visits log" * RowActionTooltipWithDimension reverted Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/Live/lang/en.json Co-authored-by: Stefan Giehl <stefan@matomo.org> * updates expected test files * Tour pluging language reworked (#19499) * updates expected test files * Transitions plugin language reworked (#19497) * Transitions plugin language reworked * Suggested changes made Co-authored-by: Stefan Giehl <stefan@matomo.org> * Launch transitions sentence Co-authored-by: Stefan Giehl <stefan@matomo.org> * UserCountry plugin language reworked (#19479) * UserCountry plugin language reworked * Suggested changes and fixes Co-authored-by: Stefan Giehl <stefan@matomo.org> * Deduplication * Steps for accurate geolocation Co-authored-by: Stefan Giehl <stefan@matomo.org> * TwoFactorAuth plugin language reworked (#19482) * TwoFactorAuth plugin language reworked * Suggested changes and clarifications made Co-authored-by: Stefan Giehl <stefan@matomo.org> * Avoiding misinterpretations * Clarifications * Spelling: your old codes Co-authored-by: Stefan Giehl <stefan@matomo.org> * prerequisite * - log in Co-authored-by: Stefan Giehl <stefan@matomo.org> Co-authored-by: Stefan Giehl <stefan@matomo.org> * fix syntax * updates expected test files * fix placeholder Co-authored-by: Allan Nordhøy <epost@anotheragency.no>
Description:
Generally shorter and to the point.
In line with other edits.
Review