@diosmosis opened this Pull Request on July 8th 2022 Member

Description:

This PR is based off every vue-remove-angularjs- PR and should be merged after they are all merged.

Changes:

  • Remove use of angularjs directives in twig templates.
  • Remove use of ng-app/ng-cloak.
  • Remove vue=>angularjs adapters in CoreHome/CorePluginsAdmin.
  • Convert zen-mode.js to use Vue code.
  • Add some extra output to vue:build + add a --bail option
  • Create MobileSideNav vue component.
  • Load menu translations client side if not in installation or updater (since plugins need to be available).

Review

@github-actions[bot] commented on July 20th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions[bot] commented on August 31st 2022 Contributor

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@sgiehl commented on September 1st 2022 Member

I've pushed a couple of fixes, but there is still one js error remaining in frontend:

Segmentation.js?cb=9198:679 Uncaught TypeError: Cannot read properties of undefined (reading 'dispatchEvent')
    at closeForm (Segmentation.js?cb=9198:679:65)
    at HTMLBodyElement.<anonymous> (Segmentation.js?cb=9198:546:21)
    at HTMLBodyElement.dispatch (jquery.min.js?cb=9198:3:7537)
    at r.handle (jquery.min.js?cb=9198:3:5620)
@diosmosis commented on September 2nd 2022 Member

@sgiehl I wasn't able to reproduce that specific error, but there were quite a few test a failures. I fixed those, hopefully it fixes whatever you were experiencing. If not, steps to reproduce would be helpful.

@sgiehl commented on September 5th 2022 Member

Seems my issue has been fixed. Will do a final review once the PRs in all submodule plugins have been reviewed and merged, so we can safely merge this one and afterwards the other PRs to remove angular.

@diosmosis commented on September 20th 2022 Member

submodules have been reviewed and merged

@github-actions[bot] commented on September 29th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@sgiehl commented on October 7th 2022 Member

@diosmosis would you mind checking why the javascript tests are failing?

This Pull Request was closed on October 10th 2022
Powered by GitHub Issue Mirror