New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent possible notice when using tracker config #19495
Conversation
update tracking config
@peterhashair Could you please explain when exactly this is an issue? (The issue number L3-264 seems invalid, so can't look up anything) |
@sgiehl This happens when you tracking a site has login function, before login and after login are record as 2 different visits under _paq.push(['trackPageView']);
_paq.push(['enableLinkTracking']);
_paq.push(['setSecureCookie', true]);
_paq.push(['setUserId',null]);
_paq.push(["setCookieDomain", "*.test"]);
_paq.push(["setDomains", "*.test"]);
_paq.push(["requireCookieConsent"]);
``` |
@peterhashair What exactly happens in that case? You now described a certain tracking use case and which problem your changes might aim to fix, but not which problem in the PHP code it tries to solve. Based on the changes in the PR, there must have been some sort of warning / error / notice in PHP (like an undefined index). |
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
@peterhashair could you answer my questions from the previous comment? |
@sgiehl sorry, I believe this PR is not valid anymore, but the problem was I can remember the code below keeps returning true. if (TrackerConfig::getConfigValue('enable_userid_overwrites_visitorid', $this->getIdSiteIfExists())) { |
The default value is |
I'll merge this one now. Even though it does not have anything to do with the referenced issue, it could under certain circumstances avoid possible notices. e.g. when accessing a tracker config value that doesn't exist. |
Description:
Review