[Vue] remove use of angularjs for expression parsing #19492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
github-actions
bot
added
the
Stale
diosmosis
added
Needs Review
github-actions
bot
removed
the
Stale
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
Stale
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
Stale
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
Stale
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
Stale
sgiehl
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
Did some basic testing in the UI for the components that are affected by the changes. Couldn't find any issues.
Btw. @diosmosis we might need to update our LEGALNOTICE and add vue.js as well as math.js maybe
|
@sgiehl updated the notice |
bx80
pushed a commit
that referenced
this pull request
Nov 25, 2022
* try replacing angularjs expression parsing w/ mathjs/number * logical operator fixes * only import what is needed for math.js * remove some functionality * optimize math.js use * built vue files * update legal notice Co-authored-by: sgiehl <stefan@matomo.org> Co-authored-by: sgiehl <sgiehl@users.noreply.github.com>
bx80
pushed a commit
that referenced
this pull request
Nov 25, 2022
* try replacing angularjs expression parsing w/ mathjs/number * logical operator fixes * only import what is needed for math.js * remove some functionality * optimize math.js use * built vue files * update legal notice Co-authored-by: sgiehl <stefan@matomo.org> Co-authored-by: sgiehl <sgiehl@users.noreply.github.com>
bx80
pushed a commit
that referenced
this pull request
Nov 25, 2022
* try replacing angularjs expression parsing w/ mathjs/number * logical operator fixes * only import what is needed for math.js * remove some functionality * optimize math.js use * built vue files * update legal notice Co-authored-by: sgiehl <stefan@matomo.org> Co-authored-by: sgiehl <sgiehl@users.noreply.github.com>
sgiehl
added
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes:
We're only using the smallest portion of math.js possible to support what fields need, but it still adds quite a bit to the bundle size.
Looking through the bundled code, it seems there's still quite a bit that's not needed. It's possible it could be excluded by directly including only what we need from individual math.js files, but I'm not sure it will have any effect in the end.
There are a handful of other expression parsing libraries, but all of them seem to be very old and unmaintained, except math.js.
Review