@diosmosis opened this Pull Request on July 7th 2022 Member

Description:

Changes:

We're only using the smallest portion of math.js possible to support what fields need, but it still adds quite a bit to the bundle size.

5 x-dev

image

Looking through the bundled code, it seems there's still quite a bit that's not needed. It's possible it could be excluded by directly including only what we need from individual math.js files, but I'm not sure it will have any effect in the end.

There are a handful of other expression parsing libraries, but all of them seem to be very old and unmaintained, except math.js.

Review

@github-actions[bot] commented on July 22nd 2022 Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions[bot] commented on July 31st 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions[bot] commented on August 8th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions[bot] commented on August 16th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

Powered by GitHub Issue Mirror