New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes row evolution for rows containing encoded entities #19490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dee851f
to
44d41c5
Compare
@bx80 Those double encoding is actually a side effect of having the goal data automatically sanitized before being stored in the database (See e.g. #4231). I've now adjusted the Goals API so it unsanitizes the data before it's returned. I've tried to check & adjust all usages of the goals to ensure this won't open up any security issues. (There were at least some tooltips where it was possible to inject html code using html in the goal name). |
0711c98
to
df278fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've spent some time checking all the places where goal names are used, I can't see any issues. There is one UI screenshot Goals_action_goals_row_evolution.png
which needs updating but other than that it all looks good 👍
This pull request has been mentioned on Matomo forums. There might be relevant details there: https://forum.matomo.org/t/warning-plugins-goals-api-php-117/47716/2 |
Description:
fixes #19485
Review