Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] remove angularjs from CustomDimensions plugin #19486

Merged
merged 6 commits into from Aug 24, 2022
Merged

[Vue] remove angularjs from CustomDimensions plugin #19486

merged 6 commits into from Aug 24, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • Remove use of angularjs directives from twig templates.
  • Remove vue => angularjs adapters.

Review

@diosmosis diosmosis added this to the 5.0.0 milestone Jul 6, 2022
@diosmosis diosmosis marked this pull request as draft July 6, 2022 22:25
@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 21, 2022
@diosmosis diosmosis added Needs Review PRs that need a code review Do not close PRs with this label won't be marked as stale by the Close Stale Issues action labels Aug 22, 2022
@diosmosis diosmosis marked this pull request as ready for review August 22, 2022 19:14
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Aug 23, 2022
sgiehl
sgiehl requested changes Aug 23, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diosmosis The code changes here are looking good. But I actually found two regressions:

  • The site selector doesn't show the currently selected site
  • The button to add a new dimensions doesn't seem to work anymore

@sgiehl sgiehl removed the Needs Review PRs that need a code review label Aug 23, 2022
@diosmosis
Copy link
Member Author

@sgiehl should be fixed + one other issue I found

sgiehl
sgiehl approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected now 👍

@sgiehl sgiehl merged commit c207ad5 into 5.x-dev Aug 24, 2022
@sgiehl sgiehl deleted the vue-remove-angularjs-CustomDimensions branch August 24, 2022 07:58
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
@diosmosis @bx80
[Vue] remove angularjs from CustomDimensions plugin (#19486)
60d8cc4 
* remove angularjs from CustomDimensions plugin

* apply after $location.url change

* support use of SiteSelector directly in vue-entry when there is nothing to respond to update:modelValue events

* if switching site during custom dimension edit and there is no dimension for that site, go back to dimension list

* rebuild
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @justinvelluppillai